[PATCH v2 1/2] platform/x86: msi-wmi: Sort scancodes numerically
From: Patryk Pilichowski
Date: Tue Oct 20 2026 - 10:41:24 EST
The scancode enum is grouped by model, so the values are not in order
and are hard to follow. The grouping is not meaningful either, as the
same event codes are used across MSI models.
Sort the enum by scancode, give every entry an explicit value and use
lowercase hex.
No functional change.
Suggested-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
Signed-off-by: Patryk Pilichowski <pat.pilichowski@xxxxxxxxx>
---
drivers/platform/x86/msi-wmi.c | 23 ++++++++++-------------
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c
index 05c35133a1b3..5369ac28f4c5 100644
--- a/drivers/platform/x86/msi-wmi.c
+++ b/drivers/platform/x86/msi-wmi.c
@@ -33,25 +33,22 @@ MODULE_ALIAS("wmi:" MSIWMI_MSI_EVENT_GUID);
MODULE_ALIAS("wmi:" MSIWMI_WIND_EVENT_GUID);
enum msi_scancodes {
- /* Generic MSI keys (not present on MSI Wind) */
- MSI_KEY_BRIGHTNESSUP = 0xD0,
- MSI_KEY_BRIGHTNESSDOWN,
- MSI_KEY_VOLUMEUP,
- MSI_KEY_VOLUMEDOWN,
- MSI_KEY_MUTE,
- /* MSI Wind keys */
WIND_KEY_TOUCHPAD = 0x08, /* Fn+F3 touchpad toggle */
- WIND_KEY_BLUETOOTH = 0x56, /* Fn+F11 Bluetooth toggle */
- WIND_KEY_CAMERA, /* Fn+F6 webcam toggle */
- WIND_KEY_WLAN = 0x5f, /* Fn+F11 Wi-Fi toggle */
- WIND_KEY_TURBO, /* Fn+F10 turbo mode toggle */
- WIND_KEY_ECO = 0x69, /* Fn+F10 ECO mode toggle */
- /* MSI Claw keys */
CLAW_KEY_VOLUMEDOWN = 0x21,
CLAW_KEY_CENTER = 0x29, /* MSI M-Center main menu */
CLAW_KEY_QUICK_LONG = 0x2a, /* MSI M-Center quick access long hold */
CLAW_KEY_VOLUMEUP = 0x32,
+ WIND_KEY_BLUETOOTH = 0x56, /* Fn+F11 Bluetooth toggle */
+ WIND_KEY_CAMERA = 0x57, /* Fn+F6 webcam toggle */
CLAW_KEY_QUICK_SHORT = 0x58, /* MSI M-Center quick access short press */
+ WIND_KEY_WLAN = 0x5f, /* Fn+F11 Wi-Fi toggle */
+ WIND_KEY_TURBO = 0x60, /* Fn+F10 turbo mode toggle */
+ WIND_KEY_ECO = 0x69, /* Fn+F10 ECO mode toggle */
+ MSI_KEY_BRIGHTNESSUP = 0xd0,
+ MSI_KEY_BRIGHTNESSDOWN = 0xd1,
+ MSI_KEY_VOLUMEUP = 0xd2,
+ MSI_KEY_VOLUMEDOWN = 0xd3,
+ MSI_KEY_MUTE = 0xd4,
};
static struct key_entry msi_wmi_keymap[] = {
{ KE_KEY, MSI_KEY_BRIGHTNESSUP, {KEY_BRIGHTNESSUP} },
--
2.56.0