Re: [PATCH] cpuidle: psci: Do not log probe deferral as an error

[Christian Loehle]

On 10/20/26 15:26, Loic Poulain wrote:
> psci_cpuidle_domain_probe() reports every failure with pr_err(),
> including -EPROBE_DEFER. dt_idle_pd_init_topology() returns that
> whenever a parent domain is not registered yet, which is a normal and
> recoverable condition, so an otherwise successful boot still logs an
> error:
> 
>   CPUidle PSCI: failed to create CPU PM domains ret=-517
> 
> Report the failure with dev_err_probe() instead, which downgrade
> -EPROBE_DEFER to a debug message while still logging genuine errors.

s/logging/returning/?

> 
> Signed-off-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>

in any case:
Reviewed-by: Christian Loehle <christian.loehle@xxxxxxx>

> ---
>  drivers/cpuidle/cpuidle-psci-domain.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c
> index b9e4ad7d43a3310a76ce62018dff0af1488e33d2..aa73a2fa14b3af4d1e3edd607e058ba96132bad7 100644
> --- a/drivers/cpuidle/cpuidle-psci-domain.c
> +++ b/drivers/cpuidle/cpuidle-psci-domain.c
> @@ -173,8 +173,7 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
>  	dt_idle_pd_remove_topology(np);
>  	psci_pd_remove();
>  exit:
> -	pr_err("failed to create CPU PM domains ret=%d\n", ret);
> -	return ret;
> +	return dev_err_probe(&pdev->dev, ret, "failed to create CPU PM domains\n");
>  }
>  
>  static struct platform_driver psci_cpuidle_domain_driver = {
> 
> ---
> base-commit: f49a343b305c0b6c19a3b50c0bbf10bcd0e2e8fd
> change-id: 20261020-cpuidle-defer-4e6184bef223
> 
> Best regards,