Re: [PATCH] blk-mq: clear stale inactive flag on hctx reuse

[Nirmoy Das]

On 20.10.26 16:13, Bart Van Assche wrote:
> On 10/20/26 5:51 AM, Nirmoy Das wrote:
> > diff --git a/block/blk-mq.c b/block/blk-mq.c
> > index 025a799f35b924d..00b75eb95dd943a 100644
> > --- a/block/blk-mq.c
> > +++ b/block/blk-mq.c
> > @@ -4002,6 +4002,7 @@ static int blk_mq_init_hctx(struct 
> > request_queue *q,
> >           goto fail;
> >         hctx->queue_num = hctx_idx;
> > +    clear_bit(BLK_MQ_S_INACTIVE, &hctx->state);
> >         hctx->tags = set->tags[hctx_idx];
>
> Why clear_bit() instead of __clear_bit()?


 No strong reason, I followed the other hctx->state 
updates. __clear_bit() should work too I think. Should I resend with that ?

> Thanks,
>
> Bart.