Re: [PATCH net-next 1/5] dt-bindings: net: add support for Toshiba TC9564

[Rob Herring (Arm)]

On Sun, 18 Oct 2026 22:01:24 -0500, Alex Elder wrote:
> The Toshiba TC9564 is an SoC that exposes two XGMAC 10 Gbps Ethernet
> interfaces, each of which is attached to an embedded PCIe function.
> 
> These XGMAC interfaces have three resets, for the MAC, PMA, and XPCS
> layers.  These resets differ from the standard two resets defined
> in "snps,dwmac.yaml".
> 
> To permit these other resets to be used, modify the way resets are
> defined in "snps,dwmac.yaml" to be similar to the way interrupts and
> their names are defined earlier in the file.  That is, rather than
> adding descriptions with the resets property values, just specify the
> maximum number of items.  Then, in the reset-names property, provide
> a list of description/constant value pairs, indicating which renames
> may be used among the (three) reset items specified.
> 
> Signed-off-by: Alex Elder <elder@xxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/net/snps,dwmac.yaml   |  26 +-
>  .../bindings/net/toshiba,tc9564-xgmac.yaml    | 327 ++++++++++++++++++
>  MAINTAINERS                                   |   7 +
>  3 files changed, 351 insertions(+), 9 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/toshiba,tc9564-xgmac.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/snps,dwmac.yaml: properties:reset-names: {'maxItems': 3, 'items': [{'oneOf': [{'description': 'GMAC stmmaceth reset', 'const': 'stmmaceth'}, {'description': 'AHB reset', 'const': 'ahb'}, {'description': 'MAC reset', 'const': 'mac-reset'}, {'description': 'PMA (Physical Medium Attachment) reset', 'const': 'pma-reset'}, {'description': 'XPCS reset', 'const': 'xpcs-reset'}, {'description': 'OCP reset (deprecated)', 'const': 'stmmaceth-ocp'}]}]} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/snps,dwmac.yaml: properties:reset-names:items:0: 'oneOf' is not one of ['const', 'deprecated', 'description', 'enum', 'not', 'pattern']
	from schema $id: http://devicetree.org/meta-schemas/string-array.yaml
Documentation/devicetree/bindings/net/toshiba,tc9564-xgmac.example.dtb: ethernet@48000 (toshiba,tc9564-xgmac): False schema does not allow True
	from schema $id: http://devicetree.org/schemas/net/toshiba,tc9564-xgmac.yaml
Documentation/devicetree/bindings/net/toshiba,tc9564-xgmac.example.dtb: ethernet-phy@1c (ethernet-phy-id004d.d101): Unevaluated properties are not allowed ('vdd18-supply' was unexpected)
	from schema $id: http://devicetree.org/schemas/net/qca,qca808x.yaml

doc reference errors (make refcheckdocs):
MAINTAINERS: Documentation/devicetree/bindings/net/toshiba,tc9564-dwmac.yaml

See https://patchwork.kernel.org/project/devicetree/patch/20261019030129.1470307-2-elder@xxxxxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.