Re: [PATCH 1/1] staging: greybus: remove unnecessary goto

[Jeremy Dean Clifton]

On 10/20/26 7:19 AM, Haasham Khan wrote:
> Signed-off-by: Haasham Khan<haasham93@xxxxxxxxx>
> ---
>   drivers/staging/greybus/loopback.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> index efc69c10cffe..284935fded12 100644
> --- a/drivers/staging/greybus/loopback.c
> +++ b/drivers/staging/greybus/loopback.c
> @@ -609,10 +609,6 @@ static int gb_loopback_async_transfer(struct gb_loopback *gb, u32 len)
>   					     request, len + sizeof(*request),
>   					     len + response_len,
>   					     gb_loopback_async_transfer_complete);
> -	if (retval)
> -		goto gb_error;
> -
> -gb_error:
>   	kfree(request);
>   	return retval;
>   }
> -- 2.53.0

A few things here:

You don't have a commit message explaining anything. You need something 
there explaining what your changing and why.

Also, it looks like you're starting a series ("1/1"). That is not needed.

I'm not sure the why you have a series here, but the big thing missing 
here is your commit message.

Jeremy Dean Clifton