Re: [PATCH net v2 1/2] net: bcmgenet: recover from a failed resume

[Florian Fainelli]

On 10/20/26 07:16, Nicolai Buchwitz wrote:
[snip]
> > [Severity: Medium]
> >
> > With WoL not in use, can this early return leave an external PHY powered
> > for the whole sleep?
>
> Yes, but IMHO also pre-existing: phy_init_hw() in the failed resume powers
> it up and it isn't started again. Before this patch suspend hung instead.
> Not leaving the half state behind is arguably a better way.
>
> > [...]
>
> I really need to find a WOL capable genet board, so I can test these 
> code paths too ....

It should be somehow possible to exercise that code path on a CM4 by 
having the system enter the "freeze" sleep state and have GENET 
configured for WoL. We can discuss offline how to get there if you are 
having issues with that.
--
Florian