Re: [PATCH v3 1/7] scsi: ufs: core: Remove an always-false WARN_ONCE()

From: Bart Van Assche

Date: Tue Oct 20 2026 - 13:00:11 EST


On 10/20/26 1:21 AM, Stanley Jhu wrote:
The WARN_ONCE() in ufshcd_poll() can never fire. completed_reqs is set
to ~tr_doorbell & hba->outstanding_reqs on the line above, and
hba->outstanding_reqs cannot change in between because ufshcd_poll()
holds hba->outstanding_lock. So completed_reqs & ~hba->outstanding_reqs
is always zero. Remove it. No functional change.

Patch 2/7 has a Cc: stable tag so this patch should have that tag too.

Anyway:

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>