Re: [PATCH v8 05/14] drm/bridge: it6505: complete poweroff even if disabling regulators fails

From: Luca Ceresoli

Date: Tue Oct 20 2026 - 13:01:39 EST


On Mon, 28 Sep 2026 00:50:10 +0100, Daniel Golle <daniel@xxxxxxxxxxxxxx> wrote:
> it6505_poweroff() returns early when regulator_disable() fails,
> leaving it6505->powered set with the IRQ already disabled. The next
> it6505_poweron() then takes its early return and never re-enables the
> IRQ, leaving the bridge deaf to hotplug and link training interrupts.
> The regulator core keeps the consumer's enable count on a failed
> disable either way, so bailing out only adds a wedged bridge on top of
> the leaked reference. Log the error and complete the power-off state
> transition instead.
>
> [...]

Reviewed-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com