Re: [PATCH v11 04/11] iommu/arm-smmu-v3: Add ARM_SMMU_FEAT_EVTQ for the event queue

[Nicolin Chen]

On Tue, Oct 20, 2026 at 11:16:54AM +0000, Mostafa Saleh wrote:
> On Mon, Oct 05, 2026 at 12:30:47PM -0700, Nicolin Chen wrote:
> > @@ -4950,7 +4959,15 @@ static void arm_smmu_setup_msis(struct arm_smmu_device *smmu)
> >  
> >  	/* Clear the MSI address regs */
> >  	writeq_relaxed(0, smmu->base + ARM_SMMU_GERROR_IRQ_CFG0);
> > -	writeq_relaxed(0, smmu->base + ARM_SMMU_EVTQ_IRQ_CFG0);
> > +
> > +	/* PRIQ's vector needs EVTQ's to be kept */
> > +	WARN_ON_ONCE(!(smmu->features & ARM_SMMU_FEAT_EVTQ) &&
> > +		     (smmu->features & ARM_SMMU_FEAT_PRI));
> > +
> 
> I can't see how we can end up in this case, I’d suggest dropping it
> if I am not missing something.

This will be gone, as the prior patch is reworked following Jason's
suggestion.

Thanks
Nicolin