Re: [PATCH v4 7/7] HID: asus: Keep the Zenbook Duo input device names

[Denis Benato]

On 10/20/26 11:24, Paolo Pisati wrote:
> hid-asus renames the input devices of the keyboards it handles to
> "Asus Keyboard", except for the ROG N-Key ones, which keep the names
> the devices report. New devices are not renamed any more, so skip the
> rename for the Zenbook Duo keyboards too: their input devices keep the
> "ASUS Zenbook Duo Keyboard" names they get without this driver.

Reviewed-by: Denis Benato <denis.benato@xxxxxxxxx>

> Suggested-by: Denis Benato <denis.benato@xxxxxxxxx>
> Signed-off-by: Paolo Pisati <p.pisati@xxxxxxxxx>
> ---
>  drivers/hid/hid-asus.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
> index 6ee2ecca864d..69894de8f6ce 100644
> --- a/drivers/hid/hid-asus.c
> +++ b/drivers/hid/hid-asus.c
> @@ -1712,10 +1712,10 @@ static int asus_probe(struct hid_device *hdev, const struct hid_device_id *id)
>  		hid_warn(hdev, "Failed to initialize backlight.\n");
>  
>  	/*
> -	 * For ROG keyboards, skip rename for consistency and ->input check as
> -	 * some devices do not have inputs.
> +	 * For ROG and Zenbook Duo keyboards, skip rename for consistency and
> +	 * ->input check as some devices do not have inputs.
>  	 */
> -	if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD)
> +	if (drvdata->quirks & (QUIRK_ROG_NKEY_KEYBOARD | QUIRK_ZENBOOK_DUO_KEYBOARD))
>  		return 0;
>  
>  	/*