Re: [PATCH] nfsd: add NFSD_CMD_FILEHANDLE_GET for root filehandle lookup

[Chuck Lever]

Hi Jeff, thanks for the patch. Review findings:

1. The selftest's proc_filehandle() cannot parse the /proc reply.
   write_filehandle() emits the handle via qword_addhex(), which
   prefixes the hex digits with "\x" (net/sunrpc/cache.c), so the
   first hexval() call fails and the function returns -EIO.

2. The new binary is missing from tools/testing/selftests/nfsd/
   .gitignore, unlike the four sibling programs listed there.

3. The yaml doc for maxsize and the kernel-doc claim the handle is
   capped at @maxsize, but the code silently clamps to NFS3_FHSIZE.
   A caller passing 128 gets a 64-byte handle with no error.

4. My sashiko instance here noted that fh_proc_mount() leaves
   self->mnt behind when mount(2) fails after mkdir() succeeds, so
   teardown's rmdir() of the tmpdir fails.

Can you send a v2 that addresses these issues?


-- 
Chuck Lever (Come to NFS bake-a-thon! https://nfsv4bat.org)