Re: [PATCH] platform/x86: hp-wmi: Disable hwmon attributes when no fans are usable

From: Ilpo Järvinen

Date: Tue Oct 20 2026 - 17:52:24 EST


On Sat, 17 Oct 2026 18:54:21 +0530, Krishna Chomal wrote:

> Currently, hp_wmi_hwmon_is_visible() checks whether fan RPM queries
> succeed before exposing fan1_input and fan2_input, but pwm1_enable
> remains visible always, even when fan support is unavailable. On some
> devices, such as certain Omnibook models, the firmware does not provide
> functional WMI fan methods. Exposing pwm1_enable on these devices can
> mislead userspace and cause fan mode changes to fail.
>
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.

The list of commits applied:
[1/1] platform/x86: hp-wmi: Disable hwmon attributes when no fans are usable
commit: e931e54edb0fae350007c4054cfbf095cc316bd8

--
i.