Re: [PATCH] platform/x86: gpd pocket fan: Cancel work before releasing GPIOs
From: Ilpo Järvinen
Date: Tue Oct 20 2026 - 17:54:46 EST
On Sat, 17 Oct 2026 23:33:53 -0400, Myeonghun Pak wrote:
> The fan worker changes the direction of both GPIOs and schedules its
> next run. Its managed cancellation action is registered before the GPIOs
> are acquired, so devres releases the GPIOs before cancelling the work. A
> running worker can therefore change a GPIO after the driver has released
> it.
>
> Register the work cancellation action after both GPIO acquisitions. This
> makes devres cancel and drain the worker before releasing either GPIO.
> No work has been queued yet if GPIO acquisition or action registration
> fails.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.
FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.
The list of commits applied:
[1/1] platform/x86: gpd pocket fan: Cancel work before releasing GPIOs
commit: 9962770049c715fc30a7b3274d8f245167c0a410
--
i.