Re: [PATCH net-next v3 0/6] net: unify symmetric netmem and page_pool refcounting

[Mina Almasry]

On Tue, Oct 20, 2026 at 3:03 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Tue, 20 Oct 2026 09:23:03 -0700 Mina Almasry wrote:
> > This is awesome. For years the skb refcounting annoyed the hell out of
> > me. I couldn't fix it on my own; there were too many edge cases I
> > didn't thoroughly understand and could break. LLMs made this possible.
> > Thanks!
>
> You should have followed more modern naming patterns tho
> get_netmem() is pretty bad IMO. PP naming is object_action()
> so netmem_ref() or netmem_inc_ref() would be better, no?

Ah, I didn't know about the modern naming. I made get_netmem mirror
get_page. I now notice it's folio_get not get_folio. I can follow up
with a cleanup when net-next reopens. I assume that will not be a lot
of code churn. I was also going to try to look into deleting and
consolidating some of the now-redundant ref-ing functions anyway.

I can also make it one of the design pricnciple in the page_pool docs
so that the LLMs pick up good naming practices moving forward.

-- 
Thanks,
Mina