Re: [PATCH net-next v3 0/6] net: unify symmetric netmem and page_pool refcounting

[Mina Almasry]

On Tue, Oct 20, 2026 at 3:13 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Tue, 20 Oct 2026 15:10:03 -0700 Mina Almasry wrote:
> > > You should have followed more modern naming patterns tho
> > > get_netmem() is pretty bad IMO. PP naming is object_action()
> > > so netmem_ref() or netmem_inc_ref() would be better, no?
> >
> > Ah, I didn't know about the modern naming. I made get_netmem mirror
> > get_page. I now notice it's folio_get not get_folio. I can follow up
> > with a cleanup when net-next reopens. I assume that will not be a lot
> > of code churn. I was also going to try to look into deleting and
> > consolidating some of the now-redundant ref-ing functions anyway.
>
> If you do it soon I think we can try to squeeze it into this merge
> window to avoid unnecessary burden for backports.
>

Let me try to get it on net-next in the next hour or 2.

> > I can also make it one of the design pricnciple in the page_pool docs
> > so that the LLMs pick up good naming practices moving forward.
>
> I don't think it's needed. I mean, if at all we should perhaps
> think about naming guidelines for all of netdev, but no time for that
> right now..

Yep, honestly, maybe even just general guidelines in an even more
global place like linux/agents. One thing that has been working well
for me is coding rules or designs in Markdown; agents inevitably pick
them up and try to code in accordance with these rules. Just spit
balling ideas, nothing concrete right now.

--
Thanks,
Mina