Re: [PATCH net v3 6/8] net: add a sysctl to opt out of virtio net hdr checksum validation

From: Willem de Bruijn

Date: Tue Oct 20 2026 - 19:13:56 EST


Michael S. Tsirkin wrote:
> On Tue, Oct 20, 2026 at 03:54:23PM -0400, Willem de Bruijn wrote:
> > > +/*
> > > + * Protects changes to virtio_net_hdr_csum_check_disabled_key and each
> > > + * net->core.sysctl_virtio_net_hdr_csum_check. Readers don't use a lock.
> >
> > it appears that they take the mutex_lock below
>
> Some of them? But
> virtio_net_hdr_csum_check_disabled doesn't, that's the point, right?
>
Yes, but the statement is then too absolute:
_some_ (or most) readers don't use a lock.