Re: [PATCH] profiling: fix sampling step on 64-bit big-endian systems

From: Andrew Morton

Date: Tue Oct 20 2026 - 20:46:48 EST


On Tue, 20 Oct 2026 17:50:24 +0100 Bradley Morgan <brads@xxxxxxxxxxxxxx> wrote:

> On 20 October 2026 17:47:22 BST, Avi Weiss <thnkslprpt@xxxxxxxxx> wrote:
> >I'm happy to try it anyway - just so I know how for future patches.
> >I'll see how many I can run through before my laptop gives up ;-)
>
> sometimes the crux is for these kinds of patches something in some cryptic
> arch gets messed up in vmlinux stage, odd right?
>
> This *makes sense* for me, off the top of my head and thinking hard id say
> this *shouldn't* do anything bad to a cryptic architecture, but I've been
> shocked in the past.

OK, read_profile() makes me question my career choices.

It starts out with totally inappropriate type choices then bandaids
over that by typecasting just about every damn thing in there. None of
it is commented, natch.

I'll grab Avi's fix for this merge window. I persuaded the
coin-operated coding machine to generate a couple of patches to fix a
pre-existing thing and to clean up that code. I'll send them
separately so Sashiko takes a look. Please review.