Re: [PATCH net-next v15 1/2] hinic3: Add ethtool statistic ops part1

From: Jakub Kicinski

Date: Tue Oct 20 2026 - 20:50:38 EST


On Thu, 15 Oct 2026 17:55:43 +0800 Fan Gong wrote:
> + HINIC3_PORT_STAT(mac_rx_1519_max_bad_pkt_num),
> + HINIC3_PORT_STAT(mac_rx_1519_max_good_pkt_num),

Isn't the 1519_max_good just the last RMON histogram bucket?

> +static struct hinic3_stats hinic3_tx_queue_stats[] = {
> + HINIC3_TXQ_STAT(gso_packets),

Isn't this the standard lso/tso counter from queue stats?