Re: [PATCH v6 14/18] nvme-fc: Use CCR to recover controller that hits an error

[Mohamed Khalfella]

On Tue 2026-10-20 13:56:38 +0200, Daniel Wagner wrote:
> On Sun, Sep 20, 2026 at 11:28:12AM -0700, Mohamed Khalfella wrote:
> > +static void nvme_fc_fencing_work(struct work_struct *work)
> > +{
> > +	struct nvme_fc_ctrl *fc_ctrl =
> > +			container_of(work, struct nvme_fc_ctrl, fencing_work);
> > +	struct nvme_ctrl *ctrl = &fc_ctrl->ctrl;
> > +	unsigned long rem;
> > +
> > +	/*
> > +	 * Tear the association down now so the LLDD can finish unregistering
> > +	 * the remoteport/localport while the fencing this controller.
> > +	 */
> 
> 
> Maybe:
> 
>           /*
>            * Tear down the association before fencing starts. Fencing can take
>            * a long time and the LLDD can't finish unregistering the
>            * remoteport/localport until all associations on it are gone.
>            * Inflight requests are held and only completed once fencing has
>            * finished.
>            */
> ?

Yes, this is better. I updated the comment just like suggested above.