Re: [PATCH v2 2/2] leds: lm3532: Avoid duplicate error messages

[Bui Duc Phuc]

Hi Lee,


> > Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> Please capitalise your name appropriately here and in the 'From:' line.
>

Dan and Cezary have discussed my name formatting before:
https://lore.kernel.org/all/ak-zMNq_gSa9g8nx@stanley.mountain/

I'd prefer to keep my current name formatting,
as I have done in my previous contributions.

> >               ret = devm_add_action(&priv->client->dev, gpio_set_low_action, priv);
> >               if (ret)
> > -                     return ret;
> > +                     return dev_err_probe(&priv->client->dev, ret,
> > +                                          "failed to add GPIO action\n");
>
> We do not usually print messages for '-ENOMEM' failures.
>
> It was better before.
>

Thanks for pointing this out.
The original code propagates the error to lm3532_probe(), where it is
already logged.
I'll keep the error propagation without adding a dev_err_probe()
message here and
return the error directly from devm_add_action() and lm3532_parse_node().

I'll send an updated version soon.

Best regards,
Phuc