Re: [PATCH net] ppp: linearize bridged packets when required
From: Qingfang Deng
Date: Tue Oct 20 2026 - 23:07:46 EST
On 2026/10/21 10:39, netdev-bot+sinfo@xxxxxxxxxx wrote:
Hi!
This is an automated message. This series looks like a fix, but its
commit messages seem to be missing some information:
- Whether the issue was actually triggered, or is only theoretical
(e.g. found by code inspection). If it was triggered please include
the symptoms, like the stack trace or error messages.
This is reproduced in a VM, with a TAP interface bridged to a PTY. When IFF_NAPI_FRAGS is set, a non-linear skb is passed to PPPoE and then to ppp_async_send() without linearization. The packet sent to the PTY then contains garbage data.
Please do not repost the series just to address the above. Instead,
reply to this email with the missing information, so that reviewers
can take it into account. If the series needs another revision for
other reasons, please include the information in the commit messages
then.
The evaluation is done by an LLM so it may be wrong, if you think
that is the case please reply and explain.