Re: [PATCH net v2 02/14] net: pse-pd: remove dead pi_get_admin_state() checks
From: Oleksij Rempel
Date: Wed Oct 21 2026 - 01:19:27 EST
On Tue, Oct 20, 2026 at 07:12:37PM +0200, Carlo Szelinsky wrote:
> pse_controller_register() already fails when a driver has no
> pi_get_admin_state() callback. So the checks for it in
> pse_pi_is_enabled() and pse_control_get_internal() are never true.
> Remove them.
>
> No functional change. It makes the next patch, which fixes an error
> path in pse_control_get_internal(), smaller.
>
> Signed-off-by: Carlo Szelinsky <github@xxxxxxxxxxxx>
Acked-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
Thank you!
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |