Re: [PATCH net v2 03/14] net: pse-pd: fix module refcount leak in pse_control_get_internal()

[Oleksij Rempel]

On Tue, Oct 20, 2026 at 07:12:38PM +0200, Carlo Szelinsky wrote:
> pse_control_get_internal() takes a module reference, but when
> pse_pi_is_hw_enabled() fails, it skips module_put(). This happens on
> any I2C or UART error. Each time, one more reference leaks, and the
> PSE driver can no longer be unloaded.
> 
> Send this error path to put_module, like the regulator_get_exclusive()
> error path.
> 
> Found by code inspection. Not reproduced.
> 
> Fixes: ffef61d6d273 ("net: pse-pd: Add support for budget evaluation strategies")
> Reviewed-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> Signed-off-by: Carlo Szelinsky <github@xxxxxxxxxxxx>

Acked-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>

Thank you!
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |