Re: [PATCH net v2 04/14] net: pse-pd: do not keep a failed IRQ in pcdev->irq

[Oleksij Rempel]

On Tue, Oct 20, 2026 at 07:12:39PM +0200, Carlo Szelinsky wrote:
> devm_pse_irq_helper() keeps the IRQ number in pcdev->irq even when the
> IRQ request failed. The failed probe then runs
> pse_controller_unregister(), which calls disable_irq() on that line. If
> another device owns it, that device stops getting interrupts.
> 
> Clear pcdev->irq when the request fails. It is now set before the
> request, because pse_isr() can run as soon as the IRQ is enabled and
> pse_pw_d_is_sw_pw_control() reads it.
> 
> Found by code inspection. Not reproduced.
> 
> Fixes: ffef61d6d273 ("net: pse-pd: Add support for budget evaluation strategies")
> Reviewed-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> Signed-off-by: Carlo Szelinsky <github@xxxxxxxxxxxx>

Acked-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>

Thank you!
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |