Re: [PATCH v3 3/4] leds: flash: lm3643: Describe the LED of ACPI boards without LED nodes

From: Andy Shevchenko

Date: Wed Oct 21 2026 - 02:38:56 EST


On Tue, Oct 20, 2026 at 02:19:46PM +0300, Sakari Ailus wrote:
> On Tue, Oct 20, 2026 at 11:45:06AM +0100, Lee Jones wrote:

...

> > Andy, et al.,
> >
> > I don't usually allow data from other registration mechanisms to be
> > passed through another (MFD data via OF for instance).
> >
> > Is this okay?

Seconding Sakari's answer, this doesn't sound like the best approach.

> In this case the ipu-bridge needs to provide the information to the lm3643
> driver via software nodes, as it already does for a number of other
> devices. There's no point in putting the information to the LED driver.
>
> Presumably the ACPI device node already exists so this should be
> straightforward. What's also missing from the sensor then is the flash-leds
> property, the lens-focus handling serves as an example.

+1 to all the above.

--
With Best Regards,
Andy Shevchenko