Re: [PATCH] scsi: mpt3sas: Register devices during SANITIZE

[vince]

Hi Laurence,
Thanks for your review and for asking about the SANITIZE initiation.

I clarified the drives' history: SANITIZE was started under Linux 6.x
or earlier, and the machine was powered off before it completed.
When the drives were later connected to a Linux 7.x system, the HBA
detected them, but mpt3sas did not register them as SCSI devices.

I have now reproduced the regression with a separate Seagate ST600MP0005
600 GB SAS HDD, serial S7M0ER6F:

1. Linux 6.18.55 LTS: I started SANITIZE OVERWRITE and verified that
   TEST UNIT READY returned NOT READY (02/04/1B), with 0.07% progress.

2. Stock Linux 7.2.11 (unpatched mpt3sas): After rebooting, the HBA
   detected the disk's SAS address (0x5000c5008e53f8e5), but the driver
   repeatedly issued REPORT LUNS / TEST UNIT READY / START UNIT.
   After 145 discovery attempts and 146 START UNIT commands, the disk
   remained absent from both sd and sg device lists. This prevents users
   from monitoring SANITIZE progress and may cause them to mistake a
   healthy drive for a failed one.

3. Patched Linux 7.2.11: After another reboot, the driver correctly
   handled the 02/04/1B condition and immediately registered the same
   disk as /dev/sda (0 B) and /dev/sg0. READ CAPACITY still reported
   SANITIZE IN PROGRESS, and a subsequent REQUEST SENSE progress query
   showed 22.58%. The other SAS disk registered normally throughout.

This confirms that a drive already sanitizing at discovery time becomes
invisible with unpatched 7.2.11, whereas the patched driver registers
it without falsely treating the media as ready.

The controlled reproduction used reboots rather than a separate full
power-cycle test. The original drives had been powered off during
SANITIZE.

I have saved the kernel boot logs, driver build IDs, device inventories,
and the full 145-attempt trace. I can provide them if helpful.

Thanks again for the Reviewed-by!

Best regards,
Vincent YUE

This email and any attachments may contain privileged and confidential information and are intended for the named addressee only. If you have received this e-mail in error, please notify the sender and delete this e-mail immediately. Any confidentiality, privilege or copyright is not waived or lost because this e-mail has been sent to you in error. It is your responsibility to check this e-mail and any attachments for viruses. No warranty is made that this material is free from computer virus or any other defect or error. Any loss/damage incurred by using this material is not the sender's responsibility. The sender's entire liability will be limited to resupplying the material.