Re: [PATCH net] dql: Reset the adjusted limit when resetting the queue
From: Eric Dumazet
Date: Wed Oct 21 2026 - 03:14:27 EST
Le mer. 21 oct. 2026 à 01:10, Hungyu Lin <dennylin0707@xxxxxxxxx> a écrit :
>
> dql_reset() resets limit and clears the cumulative queue and completion
> counts, but leaves adj_limit from the previous queue lifetime. Since
> dql_avail() subtracts num_queued from adj_limit, BQL flow control and
> qdisc bulk dequeue can use stale credit after a network queue reset,
> until the next completion updates adj_limit.
>
> Reset adj_limit to the new limit as well. With num_completed reset to
> zero, this restores the documented adj_limit = limit + num_completed
> relationship and makes the configured minimum effective immediately.
>
> Fixes: 75957ba36c05 ("dql: Dynamic queue limits")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Hungyu Lin <dennylin0707@xxxxxxxxx>
> ---
This looks correct, but the stale adj_limit only lasts until the first
TX completion after the reset, and the “negative” case matches what a
freshly initialized queue already does.
I do not think this deserves net and stable; please resend for net-next.
This will have to wait for net-next being open after the merge window.
This looks like some LLM stuff to me, with absolutely no real world impact.
pw-bot: cr