Re: [PATCH v4 08/12] drm/panthor: Refactor GEM usage flags assignment

[Boris Brezillon]

On Mon, 12 Oct 2026 14:59:36 +0200
Ketil Johnsen <ketil.johnsen@xxxxxxx> wrote:

> -static void panthor_gem_debugfs_set_usage_flags(struct panthor_gem_object *bo, u32 usage_flags)
> +static void panthor_gem_debugfs_add_usage_flags(struct panthor_gem_object *bo,
> +						u32 usage_flags)

nit: Limit has been bumped to a 100 characters per line, so let's keep
the prototype on a single line.

>  {
> -	bo->debugfs.flags = usage_flags;
> -	panthor_gem_debugfs_bo_add(bo);
> +	atomic_or(usage_flags, &bo->debugfs.flags);
>  }
>  #else
> +static void panthor_gem_debugfs_bo_add(struct panthor_gem_object *bo) {}
>  static void panthor_gem_debugfs_bo_rm(struct panthor_gem_object *bo) {}
> -static void panthor_gem_debugfs_set_usage_flags(struct panthor_gem_object *bo, u32 usage_flags) {}
> +static void panthor_gem_debugfs_add_usage_flags(struct panthor_gem_object *bo,
> +						u32 usage_flags) {}

Ditto. And if we were to have multiple lines, I'd recommend:

static void panthor_gem_debugfs_add_usage_flags(structpanthor_gem_object *bo,
						u32 usage_flags)
{
}