Re: [PATCH] wifi: ath9k: stop WMI event tasklet from rescheduling itself on probe failure

[Toke Høiland-Jørgensen]

> Fix: mirror ath9k_wmi_event_drain's pattern in the tasklet early-exit:
> if (READ_ONCE(wmi->stopped)) {
>     spin_lock_irqsave(&wmi->wmi_lock, flags);
>     __skb_queue_purge(&wmi->wmi_event_queue);
>     spin_unlock_irqrestore(&wmi->wmi_lock, flags);
>     return;
> }

I think this fix is overly verbose; we don't actually need to drain the
queue twice; if we just bail out of ath9k_wmi_event_tasklet() when the
stopped flag is set, we can drain the queue from ath9k_stop_wmi().
There's already a helper (ath9k_wmi_event_drain()) that takes the right
lock, so we can use that.

I'll send an updated patch, please drop this one.

-Toke