Re: [PATCH] staging: vme_user: use scnprintf in tsi148_alloc_resource

[David Laight]

On Wed, 21 Oct 2026 11:13:49 +0800
LiuJunyuan <2058432396@xxxxxx> wrote:

> Replace sprintf() with scnprintf() when formatting the resource name.
> 
> Signed-off-by: LiuJunyuan <2058432396@xxxxxx>
> ---
>  drivers/staging/vme_user/vme_tsi148.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c
> index 9447c00bc013..a0a7c8341995 100644
> --- a/drivers/staging/vme_user/vme_tsi148.c
> +++ b/drivers/staging/vme_user/vme_tsi148.c
> @@ -745,8 +745,8 @@ static int tsi148_alloc_resource(struct vme_master_resource *image,
>  		}
>  	}
>  
> -	sprintf((char *)image->bus_resource.name, "%s.%d", tsi148_bridge->name,
> -		image->number);
> +	scnprintf(image->bus_resource.name, VMENAMSIZ + 3, "%s.%d",

That looks like a very strange size...

David

> +		  tsi148_bridge->name, image->number);
>  
>  	image->bus_resource.start = 0;
>  	image->bus_resource.end = (unsigned long)size;