Re: [PATCH v3 2/2] phy: qcom: qmp-combo: check qmp_combo_com_init() in the typec callbacks

[Konrad Dybcio]

On 9/16/26 3:38 PM, Oleg Keri wrote:
> qmp_combo_typec_switch_set() and qmp_combo_reconfigure_phy(), which the
> typec mux callback and the USB4 init path use, tear the common block down
> and bring it straight back up on an orientation or altmode change, but
> they discard the result of the bringup:
> 
> 	qmp_combo_com_exit(qmp, true);
> 
> 	qmp->qmpphy_mode = new_mode;
> 
> 	/* Now everything's powered down, power up the right PHYs */
> 	qmp_combo_com_init(qmp, true);
> 
> 	if ((qmp->usb_init_count || qmp->usb4_init_count) &&
> 	    new_mode != QMPPHY_MODE_DP_ONLY)
> 		qmp_combo_usb_power_on(qmp->usb_phy);

Sashiko has some comments which seem valid

Is this something you hit in real life, or is that a static finding?

Konrad