Re: [PATCH v6] arm64: dts: qcom: sm8550: add Xiaomi Pad 6S Pro (sheng)

[Konrad Dybcio]

On 7/21/26 5:34 PM, Tianyuan Jiang wrote:
> From: Tianyuan Jiang <hiez832670@xxxxxxxxx>
> 
> Add device tree for Xiaomi Pad 6S Pro (sheng) based on SM8550.
> 
> Signed-off-by: Tianyuan Jiang <code_0002@xxxxxxx>

[...]

> +		/* Required for libcamera to allocate buffers when cma is used. */
> +		linux,cma {
> +			compatible = "shared-dma-pool";
> +			size = <0x0 0x30000000>;
> +			reusable;
> +			linux,cma-default;
> +		};

If you update libcamera and enable DMABUFS in the kernel, is
this still necessary?


> +&ipa {
> +	qcom,gsi-loader = "self";
> +	memory-region = <&ipa_fw_mem>;
> +	firmware-name = "qcom/sm8550/xiaomi-sheng/ipa_fws.mbn";
> +	status = "okay";

nit: please keep a \n before 'status' consistently, file-wide

[...]

> +	nanosic_mcu@4c {

Node names must not contain underscores

> +		compatible = "nanosic,wn8030-sheng";

This compatible is not documented and I see no references in your message

[...]

> +&spi4 {
> +	status = "okay";
> +
> +	touchscreen@0 {
> +		compatible = "novatek,NVT-ts-spi";

Likewise

[...]


> +&uart14 {
> +	status = "okay";
> +
> +	bluetooth {
> +		compatible = "qcom,wcn7850-bt";
> +
> +		local-bd-address = [ 00 00 00 00 00 00 ];

I assume the bootloader doesn't update this, in which case I don't
think there's a good reason to keep this property here

Konrad