Re: [PATCH RFC v2 2/2] arm64: dts: qcom: Add a minimal Xiaomi Warsaw description

[Konrad Dybcio]

On 10/16/26 5:53 PM, Zhang Jiaxi wrote:
> From: Jiaxi Zhang <z1529105815@xxxxxxxxxxx>
> 
> Add the Warsaw board identity, reference clocks, PM8550/PMK8550
> devices, key wiring and inherited debug UART route. Describe the board
> from the SoC and PMIC includes instead of inheriting all MTP devices.

[...]

> +	model = "Xiaomi Warsaw";

Google suggests that's "REDMI K90 Ultra", we usually put marketing
names in the model field

[...]

> +&qupv3_1 {
> +	status = "okay";
> +};
> +
> +&uart7 {
> +	status = "okay";
> +};

This node (and apps_rsc below) is out of alphabetical sorting order,
please touch that up:

https://docs.kernel.org/devicetree/bindings/dts-coding-style.html

> +
> +&tlmm {
> +	/* GPIOs reserved by the Warsaw firmware. */
> +	gpio-reserved-ranges = <36 4>, <48 4>, <74 1>;

Do we know what they correspond do? It's commongly NFC eSE, FP
scanner etc. If you do, please add a comment like the one in
glymur-crd.dtsi

[...]

> +&spmi_bus {
> +	#address-cells = <2>;
> +	#size-cells = <0>;
> +
> +	pmic@7 {

#include "pmih0108-kaanapali.dtsi" instead

[...]

> +&usb {
> +	phys = <&usb_hsphy>;
> +	phy-names = "usb2-phy";
> +	dr_mode = "peripheral";
> +	maximum-speed = "high-speed";
> +	qcom,select-utmi-as-pipe-clk;
> +
> +	status = "okay";

No SuperSpeed / DP altmode on this one?

Konrad