Re: [PATCH net-next v3] net: phy: realtek: Add support for JLSemi JL2101 and JL2121 PHYs

[Andrew Lunn]

> - Drop standalone driver drivers/net/phy/jlsemi.c and extend the Realtek
>   PHY driver directly as suggested by Andrew Lunn.

> +#define JLSEMI_JL2101_PHYID			0x937c4032
> +#define JLSEMI_JL2121_PHYID			0x937c4030

> +	}, {
> +		PHY_ID_MATCH_EXACT(JLSEMI_JL2101_PHYID),
> +		.name		= "JLSemi JL2101 Gigabit Ethernet",

...

> +	}, {
> +		PHY_ID_MATCH_MODEL(JLSEMI_JL2121_PHYID),
> +		.name		= "JLSemi JL2121 Gigabit Ethernet",

Do you have any documentation about these IDs? Why do you think one
should be an exact match, and the other a model match? The fact the
2102 is within the 2121 range makes this look odd to me. So it would
be good to have some explanation.

       Andrew