Re: [RFC PATCH 2/6] sched/fair: Add is_smt_buddy_run() to skip SMT domain
From: Peter Zijlstra
Date: Wed Oct 21 2026 - 08:44:02 EST
On Tue, Oct 20, 2026 at 04:37:42PM +0800, Li kunyu wrote:
> @@ -14375,7 +14390,8 @@ static void sched_balance_domains(struct rq *rq, enum cpu_idle_type idle)
>
> interval = get_sd_balance_interval(sd, busy);
> if (time_after_eq(jiffies, sd->last_balance + interval)) {
> - if (sched_balance_rq(cpu, rq, sd, idle, &continue_balancing)) {
> + if (!is_smt_buddy_run(sd, is_smt_move_task) &&
> + sched_balance_rq(cpu, rq, sd, idle, &continue_balancing)) {
Same horrific indenting fail. Surely you've read surrounding code?
> /*
> * The LBF_DST_PINNED logic could have changed
> * env->dst_cpu, so we can't know our idle
> --
> 2.47.3
>