Re: [PATCH v3 1/2] platform/x86: bitland-mifs-wmi: Fix response payload copy size

[Mingyou Chen]

On 10/21/26 07:49, TuteMthCD wrote:
> sizeof(*output->data) copies only one byte, leaving the rest
> uninitialized. Use sizeof(output->data) to copy the full 28-byte
> response payload.
>
> Signed-off-by: TuteMthCD <matias.civadda2342001@xxxxxxxxx>
> ---
>   drivers/platform/x86/bitland-mifs-wmi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/bitland-mifs-wmi.c b/drivers/platform/x86/bitland-mifs-wmi.c
> index 44b16b7b4034..522b38e9755e 100644
> --- a/drivers/platform/x86/bitland-mifs-wmi.c
> +++ b/drivers/platform/x86/bitland-mifs-wmi.c
> @@ -265,7 +265,7 @@ static int bitland_mifs_wmi_call(struct bitland_mifs_wmi_data *data,
>   	if (output) {
>   		output->return_code = return_code;
>   		output->function = function;
> -		memcpy(output->data, payload_data, sizeof(*output->data));
> +		memcpy(output->data, payload_data, sizeof(output->data));

Hi,

I've included this fix in my v13.

>   	}
>   
>   	return 0;