Re: [PATCH 14/38] arm: dts: qcom: apq8064: Align multiple property data
From: Konrad Dybcio
Date: Wed Oct 21 2026 - 09:57:32 EST
On 10/16/26 4:14 PM, Waqar Hameed wrote:
> On Mon, Oct 12, 2026 at 17:52 +0200 Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:
>
>> On 10/2/26 12:36 AM, Waqar Hameed wrote:
>>> Multiple property data on a newline should be aligned with the first one
>>> or properly indented with tabs. Found/fixed with dtfmt (Devicetree
>>> Source formatter).
>>>
>>> Signed-off-by: Waqar Hameed <waqar.hameed@xxxxxxxx>
>>> ---
[...]
> Which maybe is more clean than allowing the first string to overflow 100
> chars and aligning others to that one:
>
> clock-names = "corecorecorecorecorecorecorecorecorecorecorecorecorecorecore",
> "iface",
> "mem",
> "mem_iface";
>
> So the question is if we should either "try to fit within 100 chars, by
> adding newline after `=`" or "don't care about property data longer that
> 100 chars, always start first one after `=` on the same line". The
> latter one is of course much easier to implement :)
I have an ultrawide monitor so we can overflow waaay above 100 :D
But more seriously, between the low likelihood of this happening and
the presumed disadvantage of having to scroll sideways but still
being able to read without jumping to a different (line, col) with
your eyesight, letting super long properties overflow seems OK to
me.
Let's see if others agree
Konrad