Re: [PATCH 22/38] arm: dts: qcom: ipq8064: Break long property array data
From: Konrad Dybcio
Date: Wed Oct 21 2026 - 10:05:28 EST
On 10/16/26 4:15 PM, Waqar Hameed wrote:
> On Mon, Oct 12, 2026 at 17:31 +0200 Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:
>
>> On 10/2/26 12:36 AM, Waqar Hameed wrote:
>>> There is an awkward line break at the last elements expression. Put all
>>> elements on a newline instead. Found/fixed with dtfmt (Devicetree Source
>>> formatter).
>>>
>>> Signed-off-by: Waqar Hameed <waqar.hameed@xxxxxxxx>
>>> ---
[...]
> I think the above approach would format them quite nicely, for example
>
> swr3: soundwire@6ab0000 {
> compatible = "qcom,soundwire-v2.2.0", "qcom,soundwire-v2.0.0";
>
> ...
>
> qcom,ports-sinterval = /bits/ 16 <
> 0x07 0x1f 0x3f 0x07 0x1f 0x3f 0x18f 0xff 0xff 0x0f 0x0f 0xff 0x31f
> >;
> qcom,ports-offset1 = /bits/ 8 <
> 0x01 0x03 0x05 0x02 0x04 0x15 0x00 0xff 0xff 0x06 0x0d 0xff 0x00
> >;
> qcom,ports-offset2 = /bits/ 8 <
> 0xff 0x07 0x1f 0xff 0x07 0x1f 0xff 0xff 0xff 0xff 0xff 0xff 0xff
> >;
>
> ...
> };
>
> in `arch/arm64/boot/dts/qcom/kaanapali.dtsi`. What do you think?
I don't have any better idea so might as well
Konrad