Re: [PATCH 5/5] regulator: Add TI LM51772 support

[Uwe Kleine-König]

On Wed, Oct 21, 2026 at 12:27:46PM +0200, Paul Louvel wrote:
> +#include <linux/i2c.h>
> [...]
> +#include <linux/mod_devicetable.h>

<linux/i2c.h> already provides both of_device_id and i2c_device_id.
<linux/mod_devicetable.h> provides a plethora of more device_id structs
and thus implies a lot more build dependencies. So please drop the
latter.

> +static const struct i2c_device_id lm51772_id[] = {
> +	{ "lm51772" },

Please use a named initializer.

> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(i2c, lm51772_id);
> +
> +static struct i2c_driver lm51772_driver = {
> +	.driver = {
> +		.name = "lm51772",
> +		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
> +		.of_match_table = lm51772_of_match,
> +	},
> +	.probe = lm51772_probe,
> +	.id_table = lm51772_id

missing trailing comma

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature