Re: [PATCH v2 08/10] PCI: tegra194: Guard Endpoint PLL-off error path

[Frank Li]

On Wed, Oct 21, 2026 at 11:43:47AM +0530, Manikanta Maddireddy wrote:
> The Endpoint PERST# deassert path initializes the external-refclk PLL only
> when enable_ext_refclk is set, but the error unwind always sent the PLL-off
> request.
>
> Guard the PLL-off request with enable_ext_refclk so Tegra234 Endpoint
> configurations that did not enable the PLL do not send a spurious BPMP
> PLL-off command.
>
> Fixes: a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")
> Signed-off-by: Manikanta Maddireddy <mmaddireddy@xxxxxxxxxx>
> ---

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

> Changes V1 -> V2: None
>
>  drivers/pci/controller/dwc/pcie-tegra194.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 0e6224b6751d..de14a23f9a4d 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -1973,7 +1973,8 @@ static void pex_ep_event_pex_rst_deassert(struct tegra_pcie_dw *pcie)
>  fail_core_apb_rst:
>  	clk_disable_unprepare(pcie->core_clk);
>  fail_core_clk_enable:
> -	tegra_pcie_bpmp_set_pll_state(pcie, false);
> +	if (pcie->enable_ext_refclk)
> +		tegra_pcie_bpmp_set_pll_state(pcie, false);
>  fail_pll_init:
>  	tegra_pcie_bpmp_set_ctrl_state(pcie, false);
>  fail_set_ctrl_state:
> --
> 2.34.1
>