Re: [PATCH 11/28] mfd: intel-lpss: Remove registered MFD child devices on probe failure

[Lee Jones]

On Wed, 21 Oct 2026, Andy Shevchenko wrote:

> On Wed, Oct 21, 2026 at 12:09:33PM +0000, Lee Jones wrote:
> > When intel_lpss_has_idma() is true, intel_lpss_probe() registers the
> > iDMA64 child device via mfd_add_devices() before registering the host
> > controller cell.  If the second mfd_add_devices() call fails, the
> > err_remove_ltr error path returns without calling mfd_remove_devices(),
> > leaving the iDMA64 child device registered after the parent's
> > device-managed resources are freed.
> > 
> > Call mfd_remove_devices() on the probe error path to clean up any
> > previously registered MFD child devices, matching intel_lpss_remove().
> 
> Good catch!
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> assuming you will add Reported-by: Sashiko...

Roman suggested Closes:.

-- 
Lee Jones