Re: [PATCH 2/5] ntp: Recalculate skew_delta when the phase offset changes

From: John Stultz

Date: Wed Oct 21 2026 - 15:10:05 EST


On Thu, Oct 1, 2026 at 1:21 PM David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote:
>
> From: David Woodhouse <dwmw@xxxxxxxxxxxx>
>
> The skew rate is recomputed only by second_overflow(), so when
> time_offset or time_adjust changes mid-second (hardpps on each pulse,
> adjtimex, adjtime()) the stale rate keeps delivering until the end of
> the second, and the misdelivery lands in ntp_error. Pull the
> computation out into ntp_update_skew_delta() and call it from the
> writers. Settling of an opposing time_offset/time_adjust overlap stays
> paced at one chunk per second, via the settle argument.
>
> Signed-off-by: David Woodhouse <dwmw@xxxxxxxxxxxx>
> Assisted-by: LLM

Acked-by: John Stultz <jstultz@xxxxxxxxxx>

thanks
-john