Re: [PATCH v3 RESEND 0/3] Bluetooth: btmtk: fix ISO data reception

[Chris Lu (陸稚泓)]

Hi Luiz,

Thanks for the reminder, I've noticed the results of Sashiko's review.

On Wed, 2026-10-21 at 10:23 -0400, Luiz Augusto von Dentz wrote:
> Hi Chris,
> 
> On Wed, Oct 21, 2026 at 4:43 AM Chris Lu <chris.lu@xxxxxxxxxxxx>
> wrote:
> > 
> > Resend due to rebase: the base this series was previously posted
> > against
> > no longer exists in bluetooth-next's history, which is why it
> > failed to
> > apply. Rebased onto current bluetooth-next; no content changes from
> > v3.
> > 
> > Two fixes for btmtk_recv_isopkt(), found while debugging LE Audio
> > on
> > MT7925, plus an update to the ISO data transmission setting. The
> > function
> > is shared by every MediaTek USB controller that supports ISO data,
> > so none
> > of this is specific to that part.
> > 
> > Patch 1 drops the zero padding that the ISO interrupt IN endpoint
> > appends
> > to each transfer instead of parsing it as ISO packets.
> > 
> > Patch 2 bounds Data_Total_Length by hdev->iso_mtu.
> > 
> > Patch 3 updates the mt79xx ISO data transmission setting.
> > 
> > The three hunks do not overlap, so any prefix of the series applies
> > on its
> > own.
> > 
> > Changes in v3 RESEND:
> > - Resend due to rebase. No content changes.
> > 
> > Changes in v3:
> > - Patch 1: instead of dropping a packet solely because
> > Data_Total_Length
> >   is zero, also confirm that the rest of the transfer is zero-
> > filled
> >   before treating it as padding.
> > - Patch 2, 3: unchanged.
> > 
> > Changes in v2:
> > - Patch 2 reworked and retitled.
> > - Patch 3 added.
> > 
> > Based on bluetooth-next.
> > 
> > Chris Lu (3):
> >   Bluetooth: btmtk: drop zero-length ISO packets from endpoint
> > padding
> >   Bluetooth: btmtk: bound the ISO payload length by the
> > controller's MTU
> >   Bluetooth: btmtk: derive the firmware ISO setting from
> >     MTK_ISO_THRESHOLD
> > 
> >  drivers/bluetooth/btmtk.c | 44 ++++++++++++++++++++++++++++++++++-
> > ----
> >  1 file changed, 39 insertions(+), 5 deletions(-)
> > 
> > --
> > 2.45.2
> > 
> 
> Sashiko is still flagging a problem:
> 
> https://urldefense.com/v3/__https://sashiko.dev/*/patchset/20261021084337.1515468-1-chris.lu*40mediatek.com__;IyU!!CTRNKA9wMg0ARbw!heJ4Q7JNUGP7kU0I1b-VYacWXQtYzXNUNhsuWVeqBSzOyMw8rIeqJ_WJV187h0noHUi3xzGLwHGlcvWmCIA$
>  
> 

I'll send the next version after confirming my fix is effective and all
basic functions work normally.

Thanks,
Chris Lu