Re: [PATCH v1 5/8] arm64: dts: qcom: hawi-mtp: enable audio playback and capture

[Konrad Dybcio]

On 9/23/26 10:46 AM, Prasad Kumpatla wrote:
> Wire up the audio use cases on the Hawi MTP board on top of the LPASS
> nodes added to the SoC dtsi.
> 
> Add the sound card (qcom,hawi-sndcard) with the TDM playback, WCD
> playback/capture and VA DMIC capture DAI links and the associated audio
> routing. Describe the WCD9395 codec, enable the RX and TX SoundWire
> controllers with their WCD RX/TX satellite ports, and add the WSA8855
> speaker amplifier on i2c3. Configure the VA macro DMIC supply and the
> required TLMM pin states (WCD reset, WSA IRQ, WSA shutdown).
> 
> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@xxxxxxxxxxxxxxxx>
> ---

[...]

> +	wcd939x: audio-codec {

Nodes should be sorted by their node name in absence of a better
key (like the unit address), please move this one up


> +&i2c3 {
> +	status = "okay";
> +
> +	wsa885x: speaker@c {
> +		compatible = "qcom,wsa8855";
> +		reg = <0x0c>;
> +
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <77 IRQ_TYPE_EDGE_FALLING>;
> +
> +		pinctrl-0 = <&wsa885x_spkr_sd_n &wsa885x_irq_gpio>;
> +		pinctrl-names = "default";
> +
> +		powerdown-gpios = <&pmh0110_f_e0_gpios 11 GPIO_ACTIVE_LOW>;
> +
> +		vdd-1p8-supply = <&vreg_l2g_1p8>;
> +		vdd-io-supply = <&vreg_l1g_1p2>;
> +
> +		qcom,battery-config = "1s";
> +
> +		#sound-dai-cells = <0>;
> +
> +		status = "okay";

No one disabled it, so it's enabled by default

> +	};
> +};
> +
> +&swr1 {
> +	status = "okay";
> +	wcd_rx: codec@0,4 {

Please add a \n above

[...]

> @@ -937,6 +1129,20 @@ &tlmm {
>  			       <119 2>, /* SoCCP */
>  			       <144 2>; /* CXM UART */
>  
> +	wcd_default: wcd-reset-n-active-state {
> +		pins = "gpio161";
> +		function = "gpio";
> +		drive-strength = <16>;
> +		bias-disable;
> +	};
> +
> +	wsa885x_irq_gpio: wsa885x-irq-state {
> +		pins = "gpio77";

Please keep the entries sorted by their gpio index

Konrad