Re: [PATCH v10 03/28] KVM: VMX: Disable FRED if FRED consistency checks fail

[Binbin Wu]

On 9/12/2026 5:36 AM, Sohil Mehta wrote:
> From: "Xin Li (Intel)" <xin@xxxxxxxxx>
> 
> Do not virtualize FRED if FRED consistency checks fail.

Nit:
By code, it only does one check, so it's a bit confusing about "checks"
at the first glance.


> 
> Either on broken hardware, or when run KVM on top of another hypervisor
> before the underlying hypervisor implements nested FRED correctly.
> 
> Suggested-by: Chao Gao <chao.gao@xxxxxxxxx>
> Signed-off-by: Xin Li (Intel) <xin@xxxxxxxxx>
> Signed-off-by: Sohil Mehta <sohil.mehta@xxxxxxxxx>
> Reviewed-by: Chao Gao <chao.gao@xxxxxxxxx>

Reviewed-by: Binbin Wu <binbin.wu@xxxxxxxxxxxxxxx>

> ---
> v10:
>  - Remove the comment about why not check FRED VM-exit controls in
>    cpu_has_vmx_fred() (Sean).

Although Sean didn't want it in the comment, but is it acceptable to put
it in the changelog?

>  - Remove redundant parentheses (Sean).