Re: [PATCH v11 08/11] iommu/arm-smmu-v3-kexec: Implement is_attach_deferred()

[John Garry]

On 10/5/26 20:30, Nicolin Chen wrote:
>   					    struct arm_smmu_strtab_l2 **l2table);
> +bool arm_smmu_kdump_is_attach_deferred(struct arm_smmu_master *master);
>   #else /* CONFIG_CRASH_DUMP */
>   static inline int arm_smmu_kdump_adopt_strtab(struct arm_smmu_device *smmu)
>   {
> @@ -1331,6 +1348,12 @@ arm_smmu_kdump_adopt_deferred_l2_strtab(struct arm_smmu_device *smmu, u32 sid,
>   {
>   	return -EOPNOTSUPP;
>   }
> +
> +static inline bool
> +arm_smmu_kdump_is_attach_deferred(struct arm_smmu_master *master)
> +{
> +	return false;
> +}
>   #endif /* CONFIG_CRASH_DUMP */

This is really a comment for 06/11, but I have already commented 
there... anyway, I am curious - why use CONFIG_CRASH_DUMP and not 
CONFIG_ARM_SMMU_V3_KEXEC? If your kconfig for ARM_SMMU_V3_KEXEC changes, 
then this would need to change, right?