Re: [PATCH] spi: mtk-snfi: use min() in mtk_snand_read_page_cache()

[David Laight]

On Thu, 22 Oct 2026 15:50:20 +0530
Ninad Naik <ninadnaik07@xxxxxxxxx> wrote:

> Replace the ternary case with min() to pick the smaller of cap_len and
> req_left.
> No functional change intended. Compile tested only.
> Found using Coccinelle.
> 
> Signed-off-by: Ninad Naik <ninadnaik07@xxxxxxxxx>
> ---
>  drivers/spi/spi-mtk-snfi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-mtk-snfi.c b/drivers/spi/spi-mtk-snfi.c
> index 6e96e50fedad..bbb65a21a684 100644
> --- a/drivers/spi/spi-mtk-snfi.c
> +++ b/drivers/spi/spi-mtk-snfi.c
> @@ -1017,7 +1017,7 @@ static int mtk_snand_read_page_cache(struct mtk_snand *snf,
>  			if (req_left)
>  				memcpy(op->data.buf.in + snf->nfi_cfg.page_size,
>  				       buf_fdm,
> -				       cap_len < req_left ? cap_len : req_left);
> +				       min(cap_len, req_left));

If you are going to do that then join the lines.

David

>  		} else if (rd_offset < snf->buf_len) {
>  			u32 cap_len = snf->buf_len - rd_offset;
>