Re: [PATCH net-next v15 4/9] net: dsa: lan9645x: add basic dsa driver for LAN9645X

[Jens Emil Schulz Ostergaard]

On Mon, 2026-10-19 at 10:08 +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 0 · Medium: 1 · Low: 0
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [Medium] Nothing in the tree can bind or exercise this driver.
> 
> --
> 
> net: dsa: lan9645x: add basic dsa driver for LAN9645X
> 
> This adds a basic DSA driver for the Microchip LAN9645x switch. It covers
> switch initialization, NPI, CPU and front port setup, and phylink MAC
> configuration for the internal CuPHYs and the RGMII ports. All register
> access goes through named regmaps requested from a parent device, which
> is meant to be an MFD driver submitted in a later series.
> 
> > diff --git a/drivers/net/dsa/microchip/lan9645x/lan9645x_main.c b/drivers/net/dsa/microchip/lan9645x/lan9645x_main.c
> > new file mode 100644
> > index 0000000000000..c7de3836e6967
> > --- /dev/null
> > +++ b/drivers/net/dsa/microchip/lan9645x/lan9645x_main.c
> > @@ -0,0 +1,456 @@
> 
> [ ... ]
> 
> > +static int lan9645x_reset_switch(struct lan9645x *lan9645x)
> > +{
> > +     u32 val = 0;
> > +     int err;
> > +
> > +     /* The parent must reset the whole chip before instantiating its
> > +      * children, so the switch core is disabled when we get here. The
> > +      * sequence below must not run more than once: initializing the
> > +      * memories on a running core corrupts pointers inside the queue
> > +      * system, which eventually fills up and stops passing traffic. If the
> > +      * core is already enabled the chip was not reset, so skip it.
> > +      */
> > +     if (SYS_RESET_CFG_CORE_ENA_GET(lan_rd(lan9645x, SYS_RESET_CFG)))
> > +             return 0;
> 
> [ ... ]
> 
> > +static int lan9645x_request_target_regmaps(struct lan9645x *lan9645x)
> > +{
> > +     const char *resource_name;
> > +     struct regmap *tgt_map;
> > +
> > +     for (int i = 0; i < NUM_TARGETS; i++) {
> > +             resource_name = lan9645x_resource_names[i];
> > +             if (!resource_name)
> > +                     continue;
> > +
> > +             tgt_map = dev_get_regmap(lan9645x->dev->parent, resource_name);
> > +             if (IS_ERR_OR_NULL(tgt_map)) {
> > +                     dev_err(lan9645x->dev, "Failed to get regmap=%s\n",
> > +                             resource_name);
> > +                     return -ENODEV;
> > +             }
> 
> [Severity: Medium]
> Does anything in the tree provide these regmaps?
> 
> lan9645x_probe()->lan9645x_request_target_regmaps() asks the parent for 17
> named regmaps: gcb, qs, chip_top, rew, sys, hsio, dev0..dev8, qsys and ana.
> 
> A search of drivers/mfd/ for lan9645x or lan96455s finds nothing. That is
> still true at the end of the series, through "net: dsa: lan9645x: add port
> statistics".
> 
> The new microchip,lan96455s-switch binding requires reg and reg-names, but
> the driver never reads them. A DT node that follows the binding would
> therefore always fail probe with "Failed to get regmap=gcb".
> 
> dev_get_regmap() returns NULL, not -EPROBE_DEFER, so the probe is not
> retried if a parent appears later.
> 
> lan9645x_reset_switch() above relies on the same missing parent. When
> CORE_ENA is already set, it skips the RAM init without logging anything.
> That precondition also can't be checked without the parent driver.
> 
> The commit message says:
> 
>     The MFD driver will come in a later series, because there are
>     requirements on the number of child devices before a driver qualifies as
>     a MFD device.
> 
> Until that series lands, the driver can't be bound or tested on any in-tree
> configuration. Could this be merged together with the parent driver, or is
> there another way to bind it in the meantime?

Dismissed, intended.

the driver is meant to be instantiated by a parent MFD that owns the
register IO and registers the named regmaps before it adds its
children, similar to ocelot_ext. The parent is kept out of this series
on purpose, to avoid a series across the net and mfd trees.The MFD
support is planned as a follow-up.


> 
> --
> Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261015-dsa_lan9645x_switch_driver_base-v15-0-562f316f78b9%40microchip.com