Re: [PATCH v2 05/14] drm/msm/a8xx: Add missing a850 ifpc reglist entries

[Rob Clark]

On Thu, Oct 22, 2026 at 12:19 AM Konrad Dybcio
<konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:
>
> On 10/21/26 10:41 PM, Rob Clark wrote:
> > We want to save/restore all of the CP_PROTECT regs across IFPC.
> >
> > Signed-off-by: Rob Clark <robin.clark@xxxxxxxxxxxxxxxx>
> > ---
>
>
> >  drivers/gpu/drm/msm/adreno/a8xx_catalog.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/msm/adreno/a8xx_catalog.c b/drivers/gpu/drm/msm/adreno/a8xx_catalog.c
> > index 55a805ab438c..45cd986ad4b5 100644
> > --- a/drivers/gpu/drm/msm/adreno/a8xx_catalog.c
> > +++ b/drivers/gpu/drm/msm/adreno/a8xx_catalog.c
> > @@ -1477,6 +1477,13 @@ static const u32 a850_ifpc_reglist_regs[] = {
> >       REG_A8XX_CP_PROTECT_GLOBAL(53),
> >       REG_A8XX_CP_PROTECT_GLOBAL(54),
> >       REG_A8XX_CP_PROTECT_GLOBAL(55),
> > +     REG_A8XX_CP_PROTECT_GLOBAL(56),
> > +     REG_A8XX_CP_PROTECT_GLOBAL(57),
> > +     REG_A8XX_CP_PROTECT_GLOBAL(58),
> > +     REG_A8XX_CP_PROTECT_GLOBAL(59),
> > +     REG_A8XX_CP_PROTECT_GLOBAL(60),
> > +     REG_A8XX_CP_PROTECT_GLOBAL(61),
> > +     REG_A8XX_CP_PROTECT_GLOBAL(62),
> >       REG_A8XX_CP_PROTECT_GLOBAL(63),
>
> Sounds like we should autogen this part of the list?

yes.. but not yet :-)

> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> Konrad