Re: [PATCH net v2 2/2] net: usb: cdc_mbim: don't enable BHs in tx_fixup under netpoll
From: Simon Horman
Date: Thu Oct 22 2026 - 09:08:51 EST
On Wed, Oct 21, 2026 at 09:56:19AM +0200, Nicolai Buchwitz wrote:
> cdc_mbim_tx_fixup() has the same spin_unlock_bh() as cdc_ncm_tx_fixup().
> Under netpoll it runs pending softirqs while the txq lock is held, and
> a transmit from one of them spins on that lock.
>
> Use spin_lock_irqsave() as in cdc_ncm.
>
> Fixes: 9bf211a30b3f ("net: cdc_mbim: adding MBIM driver")
> Signed-off-by: Nicolai Buchwitz <nb@xxxxxxxxxxx>
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>